Skip to content

Commit

Permalink
Fix talent switch check on retail
Browse files Browse the repository at this point in the history
  • Loading branch information
Snakybo committed May 7, 2024
1 parent 9def186 commit d2f52e2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ The format of this changelog is based on [Keep a Changelog](https://keepachangel
### Fixed

* Fix message about using a development version showing up on non-development versions
* Fix bindings not correctly loading after talent changes in Retail

## [1.14.7] - 2024-05-01

Expand Down
6 changes: 3 additions & 3 deletions Clicked/Core/BindingProcessor.lua
Original file line number Diff line number Diff line change
Expand Up @@ -1131,7 +1131,7 @@ function Addon:UpdateBindingLoadState(binding, options)
end

-- talent selected
if ShouldPerformStateCheck("CHARACTER_POINTS_CHANGED", "PLAYER_TALENT_UPDATE") then
if ShouldPerformStateCheck("CHARACTER_POINTS_CHANGED", "PLAYER_TALENT_UPDATE", "TRAIT_CONFIG_CREATED", "TRAIT_CONFIG_UPDATED") then
--- @param entries Binding.MutliFieldLoadOption.Entry[]
--- @return boolean
local function IsTalentMatrixValid(entries)
Expand Down Expand Up @@ -1183,7 +1183,7 @@ function Addon:UpdateBindingLoadState(binding, options)
end

-- forms
if ShouldPerformStateCheck("CHARACTER_POINTS_CHANGED", "PLAYER_TALENT_UPDATE") then
if ShouldPerformStateCheck("CHARACTER_POINTS_CHANGED", "PLAYER_TALENT_UPDATE", "TRAIT_CONFIG_CREATED", "TRAIT_CONFIG_UPDATED") then
local function IsFormIndexSelected(index)
local formIndex = index - 1

Expand Down Expand Up @@ -1226,7 +1226,7 @@ function Addon:UpdateBindingLoadState(binding, options)

-- spell known
do
local checks = { "PLAYER_TALENT_UPDATE", "PLAYER_LEVEL_CHANGED", "LEARNED_SPELL_IN_TAB" }
local checks = { "PLAYER_TALENT_UPDATE", "PLAYER_LEVEL_CHANGED", "LEARNED_SPELL_IN_TAB", "TRAIT_CONFIG_CREATED", "TRAIT_CONFIG_UPDATED" }

if Addon.EXPANSION_LEVEL == Addon.EXPANSION.CLASSIC then
table.insert(checks, "RUNE_UPDATED")
Expand Down

0 comments on commit d2f52e2

Please sign in to comment.