Add types to SortedDict and add tests #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmontemayor2-sc
requested review from
mkolodner-sc,
nshah-sc,
svij-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 19:49:56UTC : 🔄 @ 19:59:16UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 19:49:56UTC : 🔄 @ 20:52:25UTC : ✅ Workflow completed successfully. |
Collaborator
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
Thanks Kyle! A general comment is that I think it'd be great if we could try to consolidate and/or reduce some of these tests here -- having so many tests here makes it a bit harder to maintain and extend upon in the future.
yliu2-sc
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of work done
We should probably start using
SortedDictmore generally, it's useful for distributed setups when we need order to be conistent.Updated the class with types and also some unit tests :)
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO