Skip to content

Arctic rollout: override Ray's default max_concurrency (1000 -> 4096) - #9

Merged
sfc-gh-mhidayetoglu merged 1 commit into
arctic_rl_share_v0.7.1from
mert/rollout-concurrency-fix
Jun 30, 2026
Merged

Arctic rollout: override Ray's default max_concurrency (1000 -> 4096)#9
sfc-gh-mhidayetoglu merged 1 commit into
arctic_rl_share_v0.7.1from
mert/rollout-concurrency-fix

Conversation

@sfc-gh-mhidayetoglu

@sfc-gh-mhidayetoglu sfc-gh-mhidayetoglu commented Jun 29, 2026

Copy link
Copy Markdown

Override ray's default max_concurrency of 1000 -> 4096 so that each engine is filled with requests at scale.

@sfc-gh-mhidayetoglu
sfc-gh-mhidayetoglu merged commit 932b560 into arctic_rl_share_v0.7.1 Jun 30, 2026
1 check passed
@sfc-gh-mhidayetoglu
sfc-gh-mhidayetoglu deleted the mert/rollout-concurrency-fix branch June 30, 2026 21:03
server = self.server_class.options().remote(
server = self.server_class.options(
# override ray's default max_concurrency of 1000
max_concurrency=4096,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard coding in this manner does not generalize. It would be better to make this an arctic config knob since it is arctic-specific.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can make it max_concurrency = #replicas x vllm.max_num_seqs

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that would be excellent. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants