Improve alarms #1336
Open
Improve alarms #1336
+153
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reinitialize alarms with threshold more sensitive and monitor process restarted. Just watch in CloudWatch for sometime to see if that make sense. |
alistair-singh
approved these changes
Nov 21, 2024
| # Scan interval(in minutes) | ||
| SCAN_INTERVAL=60 | ||
| # Scan interval(30 minutes by default) | ||
| SCAN_INTERVAL=30 |
There was a problem hiding this comment.
Do you think it would be valuable to do 15 minutes?
There was a problem hiding this comment.
I'd prefer to start from 30 minutes first.
| Value: Number( | ||
| channel.toEthereum.outbound < channel.toEthereum.inbound | ||
| ), | ||
| Value: Number(channel.toEthereum.outbound < channel.toEthereum.inbound), |
There was a problem hiding this comment.
Instead of logging booleans, maybe we should log the difference. This would then be a metric of undelivered messages.
There was a problem hiding this comment.
785b59b metrics for the difference.
web/packages/operations/src/alarm.ts
Outdated
| ? parseInt(process.env["CheckIntervalToEthereum"]) | ||
| : status.BlockLatencyThreshold.ToEthereum) && | ||
| metrics.bridgeStatus.toEthereum.latestPolkadotBlockOnEthereum <= | ||
| metrics.bridgeStatus.toEthereum.blockLatency > BlockLatencyThreshold.ToEthereum && |
There was a problem hiding this comment.
Maybe should also just log the blockLatency as a plain number instead of a boolean. Easier threshold management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCAN_INTERVALmore sensitiveResolves: https://linear.app/snowfork/issue/SNO-1233