Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple - lcobucci/jwt 5.0 #1018

Merged
merged 3 commits into from
May 13, 2023
Merged

Apple - lcobucci/jwt 5.0 #1018

merged 3 commits into from
May 13, 2023

Conversation

hamrak
Copy link
Contributor

@hamrak hamrak commented May 4, 2023

Add lcobucci/jwt 5.0 Support with fix #1015 .

@hamrak hamrak changed the title #1015 lcobucci/jwt 5.0 (#1015) May 4, 2023
@hamrak hamrak changed the title lcobucci/jwt 5.0 (#1015) lcobucci/jwt 5.0 May 4, 2023
@hamrak hamrak changed the title lcobucci/jwt 5.0 Apple - lcobucci/jwt 5.0 May 4, 2023
@atymic
Copy link
Member

atymic commented May 4, 2023

@golsson could you give this a review/test please?
Thanks!

@golsson
Copy link
Contributor

golsson commented May 4, 2023

Doesn't work for me I'm afraid:

@hamrak
Copy link
Contributor Author

hamrak commented May 4, 2023

I'm sorry, i forgot to push the last commit. Check it now.

@golsson
Copy link
Contributor

golsson commented May 5, 2023

It works now, however I can't comment on the implementation with regards to security etc. since I'm not that familiar with the concepts involved.
One thing I noticed however is the phpdoc for the plainText() "constructor", and the __constructs in both AppleSignerInMemory.php and it's parent is /** @param non-empty-string $contents */ but and empty string is hardcoded as input in Provider.php:149? For obvious reasons this doesn't cause any runtime issues but...?
Also on a side note the getTokenField($code) method can be removed since grant_type is already added in the parent. Let me know if you want me to provide a PR for that.

@hamrak
Copy link
Contributor Author

hamrak commented May 5, 2023

I will be happy, thank you @golsson .

@golsson
Copy link
Contributor

golsson commented May 5, 2023

See #1020 regarding getTokenField($code)

@atymic atymic merged commit 5cc72df into SocialiteProviders:master May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple - Broken since 5.5.0
3 participants