Release 53 #1380
Open
Release 53 #1380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: support hosting sofie under subdirectory
# Conflicts: # meteor/server/publications/buckets.ts # packages/webui/public/origo-ui/dist/origo.css # packages/webui/src/client/lib/ModalDialog.tsx # packages/webui/src/client/ui/App.tsx # packages/webui/src/client/ui/FloatingInspectors/VTFloatingInspector.tsx # packages/webui/src/client/ui/Header.tsx # packages/webui/src/client/ui/RundownView.tsx # packages/webui/src/client/ui/RundownView/SwitchboardPopUp.tsx # packages/webui/src/client/ui/SegmentStoryboard/StoryboardPartSecondaryPieces/StoryboardSecondaryPiece.tsx # packages/webui/src/client/ui/Settings.tsx # packages/webui/src/client/ui/Status.tsx # packages/webui/src/client/ui/Status/MediaManager.tsx # packages/webui/src/client/ui/SupportPopUp.tsx # packages/webui/src/client/ui/TestTools/index.tsx # packages/yarn.lock
feat: Director's Screen # Conflicts: # packages/documentation/docs/user-guide/features/sofie-views-and-screens.mdx
…ease53 # Conflicts: # packages/job-worker/src/ingest/__tests__/syncChangesToPartInstance.test.ts
Modernizing Core tech stack
fix: bad header-clear merge
(they where accidentally removed during the remormatting)
…vice-page-crash fix: PeripheralDevice.configManifest is an optional field
…entBusListener` helper
This is not complete, but is a good start
…ause non-existent documents in the publication to be removed
* chore: tidy protectedString reexports * chore: replace createManualPromise with Promise.withResolvers * chore: remove remaining tempLib reexports from meteor * chore: tidy protectedString reexports * chore: remove remaining tempLib reexports from webui
Co-authored-by: Simon Rogers <[email protected]>
No functional change, just a chore to have types aligned
* chore: update docs broken links * chore: update docusaurus
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| validLicenses = strs.map(str => new RegExp(str), 'i') | ||
| const strs = m[1].split(","); | ||
| console.log(`Valid licenses: ${strs.join(", ")}`); | ||
| validLicenses = strs.map((str) => new RegExp(str), "i"); |
Check failure
Code scanning / CodeQL
Regular expression injection High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 21 days ago
To fix the problem, we need to escape any special regex metacharacters in the user-provided license names before constructing a RegExp. The most robust and widely-accepted approach is to use the _.escapeRegExp function from the lodash package, producing literals out of any strings that contained special regex characters. This prevents injection and ensures that patterns only match the intended literal license names.
Steps:
- Add a
lodashimport (const _ = require('lodash');) at the top. - Update line 15 so each
stris sanitized using_.escapeRegExpbefore passing into the RegExp constructor. - (Unrelated but possibly important: move the "i" flag into the RegExp constructor rather than Array.map's second parameter, but this is not the focus here.)
Suggested changeset
2
scripts/checkLicenses.js
| @@ -1,4 +1,5 @@ | ||
| const legally = require("../meteor/node_modules/legally"); | ||
| const _ = require('lodash'); | ||
|
|
||
| // Usage: node checkLicenses.js --allowed=MIT,ISC --excludePackages=badPackageWhoDoesntSpeficyLicense | ||
|
|
||
| @@ -12,7 +13,7 @@ | ||
| if (m) { | ||
| const strs = m[1].split(","); | ||
| console.log(`Valid licenses: ${strs.join(", ")}`); | ||
| validLicenses = strs.map((str) => new RegExp(str), "i"); | ||
| validLicenses = strs.map((str) => new RegExp(_.escapeRegExp(str), "i")); | ||
| } | ||
|
|
||
| m = argString.match(/--excludePackages=(.*)/); |
package.json
Outside changed files
| @@ -43,5 +43,8 @@ | ||
| "semver": "^7.6.3", | ||
| "snyk-nodejs-lockfile-parser": "^1.58.16" | ||
| }, | ||
| "packageManager": "[email protected]" | ||
| "packageManager": "[email protected]", | ||
| "dependencies": { | ||
| "lodash": "^4.17.21" | ||
| } | ||
| } |
This fix introduces these dependencies
| Package | Version | Security advisories |
| lodash (npm) | 4.17.21 | None |
Copilot is powered by AI and may make mistakes. Always verify output.
Changes in this commit: Split schemas into modular components with inheritance to reduce duplication Introduce channels for improved documentation structure and clarity Recursively resolve example references Generate a merged asyncapi.yaml for tooling compatibility (e.g., Postman) Reorganize schema directory structure Update references, filenames, and fix spelling inconsistencies Remove deprecated/unused schema files and scripts Improve generated documentation and clean up formatting Generate types for client-sent messages
…schema chore: refactor lsg asyncapi schema
* chore: disable running postinstall * chore: add yarn minimal age gate * chore: run dependabot for meteor and packages dirs
feat: add notifications to lsg
…ge-dismiss Fix dismissing long messages
Instead of redirecting to root of site.
Based on 4x4 grid layout Squeeze camera and overlay views to half height in order to fit prompter. Use checkerboard pattern for backgrounds to emphasise transparent nature of overlay window
Only for the various countdown pages themselves
Package Manager types update
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sofie-Automation/Sofie-TV-automation#58
Info to developers
This release includes a significant refactor/reformatting that affects a large part of the code base. If you want to submit contributions to release53 based on release52, please read the instructions in the Modernizing tech stack PR.