Skip to content

Conversation

@rjmunro
Copy link
Contributor

@rjmunro rjmunro commented Nov 27, 2025

About the Contributor

This pull request is posted on behalf of the BBC.

Type of Contribution

This is a Feature

Current Behavior

If you are using Sofie's AB playback features to allocate clips to players, it is hard to know which player will play the next clip. This can be important, e.g. if the sound is being mixed manually.

New Behavior

Icons are now available on the directors screen indicating which player will be used for a clip. What kind of clips and when can be set in the configuration.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR affects directors view and adds a settings screen. It also makes extra controls available to blueprints.

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 55.88235% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
meteor/server/publications/showStyleUI.ts 0.00% 9 Missing ⚠️
meteor/server/migration/upgrades/showStyleBase.ts 73.91% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@rjmunro rjmunro changed the base branch from main to release53 November 27, 2025 17:32
@rjmunro rjmunro force-pushed the rjmunro/directors-view-show-ab branch 5 times, most recently from e3778a9 to 94bda04 Compare December 8, 2025 15:34
@rjmunro rjmunro force-pushed the rjmunro/directors-view-show-ab branch from 3e56076 to 94bda04 Compare December 9, 2025 11:11
@Saftret Saftret added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Dec 10, 2025
@Saftret Saftret marked this pull request as ready for review December 11, 2025 10:56
@Saftret Saftret requested a review from a team as a code owner December 11, 2025 10:56
@Saftret Saftret requested review from Copilot and removed request for Copilot December 11, 2025 10:56
@rjmunro rjmunro force-pushed the rjmunro/directors-view-show-ab branch from 94bda04 to 2751986 Compare December 11, 2025 12:58
@rjmunro rjmunro force-pushed the rjmunro/directors-view-show-ab branch from 2751986 to 8a370d3 Compare December 11, 2025 13:15
@rjmunro rjmunro force-pushed the rjmunro/directors-view-show-ab branch from 8a370d3 to f46cd9d Compare December 11, 2025 14:00
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
3.8% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contribution from BBC Contributions sponsored by BBC (bbc.co.uk)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants