-
Notifications
You must be signed in to change notification settings - Fork 54
feat: Add links to different studio screens and add a multiview for development and testing #1567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
a4fe488 to
3ef2280
Compare
Please ignore Sonar's issue with Code Coverage in this PR (we're in the process of tuning it). |
3ef2280 to
e69f9b5
Compare
Instead of redirecting to root of site.
Based on 4x4 grid layout Squeeze camera and overlay views to half height in order to fit prompter. Use checkerboard pattern for backgrounds to emphasise transparent nature of overlay window
Only for the various countdown pages themselves
jstarpl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any particular problems, but I do see that while there's a header on the main "countdowns landing page":
There is none if I go to a non-existant countdown variant, but I still get the list:
It's not a big thing, but I think it would be nice if we either kept the fallback redirect, in case someone opens a page that doesn't exist, or have the header always if our new policy is to show this page now for anything starting with /countdowns.
e69f9b5 to
bccefe4
Compare
|
I've made the routes exact only and added a pseudo-404 page. |


About the Contributor
Type of Contribution
This is a Feature
Current Behavior
If you start at the URL of, for example, a directors screen (e.g. http://localhost:3005/countdowns/studio0/director) and go up a level (e.g. http://localhost:3005/countdowns/studio0/), it would redirect you to the home page of Sofie. Also there are several available views for a studio (Presenter Screen, Director Screen, Overlay Screen, Camera Screen
Prompter, Active Rundown and it's hard to remember them all
New Behavior
If you go to a URL like http://localhost:3005/countdowns/studio0/ you get a list of the main views available:
I've also made a multiView which shows most of them all in iframes, which is great for testing.
Currently this page is not itself listed anywhere. A page should be added to enumerate all the available studios and link to these views. But we may want to move some things around and add some redirects first because having most of these views under /countdowns/ possibly doesn't make sense.
Testing
Affected areas
This PR adds a couple of per-studio pages, neither of which has any active code, just links to already existing pages.
Time Frame
Status