Skip to content

Conversation

@rjmunro
Copy link
Contributor

@rjmunro rjmunro commented Nov 27, 2025

About the Contributor

Type of Contribution

This is a Feature

Current Behavior

If you start at the URL of, for example, a directors screen (e.g. http://localhost:3005/countdowns/studio0/director) and go up a level (e.g. http://localhost:3005/countdowns/studio0/), it would redirect you to the home page of Sofie. Also there are several available views for a studio (Presenter Screen, Director Screen, Overlay Screen, Camera Screen
Prompter, Active Rundown and it's hard to remember them all

New Behavior

If you go to a URL like http://localhost:3005/countdowns/studio0/ you get a list of the main views available:

image

I've also made a multiView which shows most of them all in iframes, which is great for testing.

image

Currently this page is not itself listed anywhere. A page should be added to enumerate all the available studios and link to these views. But we may want to move some things around and add some redirects first because having most of these views under /countdowns/ possibly doesn't make sense.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR adds a couple of per-studio pages, neither of which has any active code, just links to already existing pages.

Time Frame

  • Not urgent, but we would like to get this merged into the in-development release.

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@rjmunro rjmunro marked this pull request as ready for review November 27, 2025 17:35
@rjmunro rjmunro requested a review from a team as a code owner November 27, 2025 17:36
@rjmunro rjmunro force-pushed the rjmunro/link-to-views branch 2 times, most recently from a4fe488 to 3ef2280 Compare November 28, 2025 10:00
@nytamin
Copy link
Member

nytamin commented Dec 1, 2025

Quality Gate Failed Quality Gate failed

Failed conditions 0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Please ignore Sonar's issue with Code Coverage in this PR (we're in the process of tuning it).

@rjmunro rjmunro force-pushed the rjmunro/link-to-views branch from 3ef2280 to e69f9b5 Compare December 4, 2025 13:28
@rjmunro rjmunro changed the title feat: Add links to different studio views and add a multiview for development and testing feat: Add links to different studio screens and add a multiview for development and testing Dec 5, 2025
Instead of redirecting to root of site.
Based on 4x4 grid layout

Squeeze camera and overlay views to half height in order to fit prompter.

Use checkerboard pattern for backgrounds to emphasise transparent nature of overlay window
Only for the various countdown pages themselves
Copy link
Contributor

@jstarpl jstarpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any particular problems, but I do see that while there's a header on the main "countdowns landing page":

Image

There is none if I go to a non-existant countdown variant, but I still get the list:

Image

It's not a big thing, but I think it would be nice if we either kept the fallback redirect, in case someone opens a page that doesn't exist, or have the header always if our new policy is to show this page now for anything starting with /countdowns.

@rjmunro rjmunro force-pushed the rjmunro/link-to-views branch from e69f9b5 to bccefe4 Compare December 9, 2025 17:39
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@rjmunro
Copy link
Contributor Author

rjmunro commented Dec 10, 2025

@jstarpl

I don't see any particular problems, but I do see that while there's a header on the main "countdowns landing page":

It's not a big thing, but I think it would be nice if we either kept the fallback redirect, in case someone opens a page that doesn't exist, or have the header always if our new policy is to show this page now for anything starting with /countdowns.

I've made the routes exact only and added a pseudo-404 page.

@rjmunro rjmunro requested a review from jstarpl December 10, 2025 15:08
@jstarpl jstarpl merged commit f7afd72 into release53 Dec 10, 2025
68 of 69 checks passed
@jstarpl jstarpl deleted the rjmunro/link-to-views branch December 10, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants