[객체 지향 설계 및 디자인 패턴 실전 tdd 스터디] 이장원 프리코스 1차 과제 제출입니다. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long9725
reviewed
Jul 15, 2024
There was a problem hiding this comment.
Application 클래스가 Controller 역할인걸까요?
There was a problem hiding this comment.
생성자에 있는 while 문을 새로운 클래스 또는 메소드로 extract 해보세요!
There was a problem hiding this comment.
타입 안정성을 갖기 어려운 HashMap 보다는 클래스로 묶어보는게 어떨까요? 용도를 보아하니 구조체처럼 쓰신 것 같아서요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.