Fix no overhang reverse in Arachne #5964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vovodroid
force-pushed
the
fix-no-revert-arachne-pr
branch
from
62d7722
to
9486338
Compare
vovodroid
force-pushed
the
fix-no-revert-arachne-pr
branch
from
9486338
to
75b02bb
Compare
vovodroid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently overhangs detected by Detect overhang walls option with
m_lower_slices_polygons = offset(*this->lower_slices, float(scale_(+nozzle_diameter / 2)))are not marked assteep_overhang_*****intraverse_extrusionsfor Arachne, thus overhang perimeters is not reversed. Probably unified overhangs algorithm detection should be considered as proposed in Remove "Detect ovehang walls" option and use threshold #5947Revert all case.
Classic
overhangs are reversed
Arachne
Not reversed
Classic
Internal is also reversed
Arachne
Not reversed
Reverse internal only case.
Classic
Overhangs also are reversed as if there were internal:
Arachne
Not reversed
This PR makes Arachne behavior consistent with Classic.