Arachne: Fix an arithmetic overflow that causing extra points outside plate #7330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 1, 2024
|
Somehow the fix doesn't work in Release mode, the optimizer might did some funny things to it. Use a different approach this time. |
|
FYI, just tested the windows installer generated from this build (click details below "All checks have passed", then go to "summary" to find the generated files, i.e. https://github.com/SoftFever/OrcaSlicer/actions/runs/11650728839?pr=7330) which would easily fit on a Voron2.4 300 |
3 tasks
|
This fixes the instances I have seen of this issue also. |
Closed
3 tasks
Closed
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6949
Fix #7321