-
-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build_deps.yml (add missing '-p' for mkdir) #7337
base: main
Are you sure you want to change the base?
Update build_deps.yml (add missing '-p' for mkdir) #7337
Conversation
Fixes "Build on Windows" so an error isn't thrown if the working directories already exist.
@SoftFever this PR is very simple. Just added '-p' to a couple of mkdir commands for building Windows deps. |
@Noisyfox ... do these changes appear to be correct? Without the "-p", the simple act of making the build directory results in an error if the directory already exists, thereby preventing the deps from being built. |
I don't think |
From what I've seen, the YAML files on Github appear to be processed with Linux. There are four other "mkdir -p" instances in the original file, so I just copied that. I tried building the deps numerous times without success, but adding the "-p" did the trick. I Googled for >> "An item with the specified name" "already exists." << and found that it is specific to PowerShell. So that's interesting. But PowerShell doesn't support "-p" for mkdir. |
@Noisyfox I think I figured out why adding the "-p" fixed the issue; the argument is invalid in PS, so it didn't attempt to create the directory. I'll correct it a different way and update the PR. Thanks for your help! |
Fixes "Build on Windows" so an error isn't thrown if the working directories already exist. I simply added "-p" to the mkdir commands.
Screenshots/Recordings/Graphs
Before the change:
Will need testing, but it is a simple change to bring "Build on Windows" in line with the other OS builds.