Fix FanMover and thus filament purge on Bambu Lab P and X series when the "filament speed-up time" feature is used #7708
+357
−323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and thus "fan speed-up time" and "fan kick-start time" Squashed commit of the following: commit 822c91b49cb718ac9bd42ff512e875f95b84d47f Author: Thomas Scheiblauer <[email protected]> Date: Sat Dec 7 19:19:31 2024 +0100 remove "only overhangs" option from FanMover ... which could never have worked in OrcaSlicer anyway because the required overhang markers are not written into the gcode. Its use is questionable anyway because compensating for a fan delay makes sense everywhere the fan is used. commit 37f22971d36a384480861a31e3a12ca7274d9be7 Author: Thomas Scheiblauer <[email protected]> Date: Sat Dec 7 18:48:36 2024 +0100 fix issue with FanMover modifying filament change g-code which resulted in poop chute fill ups commit 6946218564d7aad3b6f90ad9298683abefd20c11 Author: Thomas Scheiblauer <[email protected]> Date: Fri Dec 6 21:11:51 2024 +0100 fix danglin-else warning commit 01144df3cef845a927990566dc2efe011649cccf Author: supermerill <[email protected]> Date: Tue Feb 13 19:21:56 2024 +0100 Fix fan mover kickstart supermerill/SuperSlicer#4113 commit 14506d7f8e077786298031e5fa3e7eacbd102591 Author: supermerill <[email protected]> Date: Mon Jan 29 19:54:49 2024 +0100 Fix fan_mover/gcodeprocessor with G2/G3 supermerill/SuperSlicer#4061
|
Nice one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes "fan speed-up time" and "fan kick-start time" and the problem with FanMover removing the fan stop commands from the filament profiles filament change g-code.
Removes the "only overhangs" option from "fan speed-up time" since IMHO it does not make sense to correct fan speed-up latency only for overhangs. Fan latency is fan latency, regardless of extrusion role.
The implementation that had been merged in from SuperSlicer couldn't have worked anyway, since the overhang markers checked by FanMover, which is implemented as a g-code filter, are not written into the g-code by OrcaSlicer.
Fixes issues #7639 and #2144.
Tests
I verifyed the produced G-Code by reading it, examined the fan speed view in the layer preview and checked if the filament change g-code from the filament profile is now working correctly.