Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managing bindings in bindable RecyclerView adapter and view holders #561

Merged

Conversation

pavel-leonenko
Copy link
Contributor

Description

Added possibility to

  • manually attach and detach bindings of all existing ViewHolders managed by a BindableRecyclerViewAdapter;
  • manually dispose all subscriptions inside BindableRecyclerViewAdapter when they are no longer needed (typically in Fragment.OnDestroyView.

API Changes

Added:

interface IBindableRecyclerViewAdapter:
 - void DoAttachBindings()
 - void DoDetachBindings()
 - void CleanUp()

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

PR Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code styles
  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@github-actions github-actions bot added c/bindings Related to Bindings component. p/Android Related to Android platform. labels Sep 23, 2024
dimysa
dimysa previously approved these changes Sep 24, 2024
dimysa
dimysa previously approved these changes Sep 25, 2024
@pavel-leonenko pavel-leonenko merged commit 73280be into project/PH1 Sep 27, 2024
1 check passed
@pavel-leonenko pavel-leonenko deleted the feature/controlling-bindings-in-bindable-adapter branch September 27, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/bindings Related to Bindings component. p/Android Related to Android platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants