Fix connectivity android #568
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| // Developed by Softeq Development Corporation | ||
| // http://www.softeq.com | ||
|
|
||
| using AndroidX.Lifecycle; | ||
| using Microsoft.Maui.Networking; | ||
| using Softeq.XToolkit.Common.Droid; | ||
| using Softeq.XToolkit.Common.Threading; | ||
| using Softeq.XToolkit.Common.Weak; | ||
|
|
||
| namespace Softeq.XToolkit.Connectivity.Droid | ||
| { | ||
| /// <summary> | ||
| /// Droid implementation of <see cref="DroidConnectivityService"/>. | ||
| /// </summary> | ||
| public class DroidConnectivityService : EssentialsConnectivityService | ||
| { | ||
| private readonly AppLifecycleObserver _lifecycleObserver; | ||
| private readonly WeakAction _startAction; | ||
|
|
||
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="DroidConnectivityService"/> class. | ||
| /// </summary> | ||
| /// <param name="connectivity"> | ||
| /// Custom instance of <see cref="T:Microsoft.Maui.Networking.IConnectivity"/> | ||
| /// or you can use <see cref="Default"/> static method. | ||
| /// </param> | ||
| public DroidConnectivityService(IConnectivity connectivity) : base(connectivity) | ||
| { | ||
| _startAction = new WeakAction(OnAppStart); | ||
|
There was a problem hiding this comment. Do you need |
||
| _lifecycleObserver = new AppLifecycleObserver(startAction: _startAction); | ||
| Execute.BeginOnUIThread(() => | ||
| { | ||
| ProcessLifecycleOwner.Get().Lifecycle.AddObserver(_lifecycleObserver); | ||
| }); | ||
| } | ||
|
|
||
| ~DroidConnectivityService() | ||
| { | ||
| Dispose(false); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Releases the unmanaged and optionally the managed resources. | ||
| /// </summary> | ||
| /// <param name="disposing"><c>true</c> to dispose managed state.</param> | ||
| /// <seealso cref="Dispose"/> | ||
| /// <seealso cref="T:System.IDisposable"/> | ||
| protected virtual void Dispose(bool disposing) | ||
|
There was a problem hiding this comment. Please add additional public method: public void Dispose()
{
Dispose(true);
GC.SuppressFinalize(this);
}to be able to remove observer from outside |
||
| { | ||
| if (disposing) | ||
| { | ||
| Execute.BeginOnUIThread(() => | ||
| { | ||
| ProcessLifecycleOwner.Get().Lifecycle.RemoveObserver(_lifecycleObserver); | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| private void OnAppStart() | ||
| { | ||
| Connectivity.ConnectivityChanged -= CurrentConnectivityChanged; | ||
| Connectivity.ConnectivityChanged += CurrentConnectivityChanged; | ||
| CurrentConnectivityChanged(this, new ConnectivityChangedEventArgs(Connectivity.NetworkAccess, Connectivity.ConnectionProfiles)); | ||
|
There was a problem hiding this comment. Is it really necessary to manually trigger an event only on Start at this place? |
||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFramework>net8.0-android</TargetFramework> | ||
| <SupportedOSPlatformVersion>21</SupportedOSPlatformVersion> | ||
| <Nullable>enable</Nullable> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <ProjectReference Include="..\Softeq.XToolkit.Common.Droid\Softeq.XToolkit.Common.Droid.csproj" /> | ||
| <ProjectReference Include="..\Softeq.XToolkit.Connectivity\Softeq.XToolkit.Connectivity.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Maui.Essentials" Version="$(MauiVersion)" /> | ||
| </ItemGroup> | ||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main reason for
Commonprojects is 'no 3rd-party dependencies'