Quick fix for adminjs-upload plugin #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dziraf
requested changes
Nov 21, 2023
| }; | ||
|
|
||
| //@ts-ignore | ||
| Array.prototype.asyncMap = async function (callback) { |
There was a problem hiding this comment.
Extending native prototypes is a bad practice, please create a helper method for this or simply use Promise.all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During file upload adminjs-upload relays on file.path https://github.com/SoftwareBrothers/adminjs-upload/blob/master/src/features/upload-file/providers/aws-provider.ts#L66 which is not provided by fastifyMultipart. TO quickly fix it in our project I created a temporary file (in tmp folder, but is not being deleted) and substituted instead of file object