Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgres-parser): use current schema name in getProperties method #18

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

czaaru
Copy link
Contributor

@czaaru czaaru commented Apr 22, 2024

Using the current schema in postgres parser has been added here: #6 but It's still missing in getProperties method.

@czaaru
Copy link
Contributor Author

czaaru commented Apr 22, 2024

Error: src/dialects/postgres.parser.ts(140,16): error TS2416: Property 'getProperties' in type 'PostgresParser' is not assignable to the same property in base type 'BaseDatabaseParser'.

@dziraf build failed, I added missing schemaName to BaseDatabaseParser

@czaaru
Copy link
Contributor Author

czaaru commented Jun 13, 2024

@dziraf any chance this will be merged soon? 🙏

@dziraf dziraf merged commit 94f029e into SoftwareBrothers:main Jun 14, 2024
3 checks passed
Copy link

🎉 This PR is included in version 2.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants