Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Using provided schema if present #21

Merged

Conversation

jakobcvetko
Copy link
Contributor

When providing the schema option to force using specified schema, this option is ignored in postgres.parsers.ts file.
This PR fixes this so that forced schema is prefered.

const pgbossDb = await new Adapter('postgresql', {
  connectionString: dbUrl,
  database: 'database',
  schema: 'pgboss',
}).init();

@dziraf dziraf merged commit 6a8e85e into SoftwareBrothers:main Jul 4, 2024
3 checks passed
@jakobcvetko
Copy link
Contributor Author

Thank you @dziraf I appreciate the quick turnaround.
I was waiting for CI to build a new version so I could use it in my project, but unfortunately it didn't happen.
Any idea why?

@dziraf
Copy link
Contributor

dziraf commented Jul 10, 2024

@jakobcvetko my bad, I merged without checking the commit message. The message must be prefixed with fix: or feat: to create a new version: https://github.com/semantic-release/semantic-release

I've just pushed another fix: commit to the main branch and the new release should include your changes when it's up.

Copy link

🎉 This PR is included in version 2.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jakobcvetko
Copy link
Contributor Author

Ahh sorry about that and thank you for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants