feat: custom endpoint for amazon s3 #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows the user to specify a function for calculating `key` field in the database. if the `recordPath` property is set, on-the-fly path calculation at frontend is disabled, and the function is then used to calculate `key` in the database.
This reverts commit 1b4a312.
|
Also, PR#34 might be covered by this, since minio is compatible with S3. |
|
@dziraf any chance to this MR be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As many object-storage service providers other than Amazon provide S3-compatible APIs, being able to configure custom endpoints different from
s3.amazonaws.comallows several third-party providers (e.g. Tencent Cloud, Alibaba Cloud) to be used. For example, after settingendpointtocos.ap-guangzhou.myqcloud.com, Tencent Cloud object storage can act as a drop-in replacement for Amazon S3.This commit adds a new key in
AWSOptionscalledendpoint. If specified, it will be used for all AWS S3 SDK calls, as well as calculating the path used for frontend preview.