fix: allow bundling .mjs and .mts files via ComponentLoader #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomups
changed the title
tomups
changed the title
dziraf
approved these changes
Nov 14, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
## [7.3.1](v7.3.0...v7.3.1) (2023-11-14) ### Bug Fixes * add support for bundling .mjs and .mts files via component-loader ([#1576](#1576)) ([2d4196f](2d4196f))
|
🎉 This PR is included in version 7.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using AdminJS with CommonJS projects (like NestJS), the only way I could have custom React components working has been by putting them into
.mjsfiles (this unfortunately loses typing as TypeScript doesn't support.mtsx, but that's how it is...)Currently,
ComponentLoaderdoesn't allow this file extension, but I don't think there is any problem by allowing them? It worked for me at least, so here is the change :)