Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for negative num_top_articles to select ascending top art… #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mrober01
Copy link
Contributor

…icles

@SomeOddCodeGuy
Copy link
Owner

I like it!

Could you update your section in the readme for it?

@mrober01
Copy link
Contributor Author

mrober01 commented Jan 19, 2025 via email

@SomeOddCodeGuy
Copy link
Owner

I think that it autocommitted on your main, but not my main.

Looking at them, your main is 2 ahead of mine, and I see your readme change: https://github.com/mrober01/OfflineWikipediaTextApi/tree/main?tab=readme-ov-file#example-curl-command-1

My main doesn't have it though:
https://github.com/SomeOddCodeGuy/OfflineWikipediaTextApi?tab=readme-ov-file#example-curl-command-1

Also, the branch you're PRing into my main is behind both mains:
https://github.com/mrober01/OfflineWikipediaTextApi/tree/OfflineWikiTopNArticles

I think you need to pull your main into your OfflineWikiTopNArticles branch, and then it'll update this PR with those readme changes.

@mrober01
Copy link
Contributor Author

mrober01 commented Jan 19, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants