Refactoring DCE #496
Closed
Refactoring DCE #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Render correct value in application revisionHistoryLimit - Remove extra spaces in 'key: value' pairs - Render correct value for application extraInitContainers
- Added helpers for labels - Fixed template expression's indentation - Fixed whitespace processing - Replace 'if' conditions by 'with' where applicable - Use 'sonarqube.serviceAccount' template in SCC - Remove rendering of '.Values.resource'
- Remove headless service for app Deployment - Remove deprecated annotation from search headless service - Specify service type for search headless service - Simplify LoadBalancer values rendering
- Remove unused "postgresql.fullname" - Remove useless "common.capabilities.policy.apiVersion" (chart requires Kubernetes > 1.24) - Simplify conditions in "jdbc.secret"
- Added additional named templates for common init containers - Move volumeClaimTemplates section to bottom - Write simple commands in one line
|
Hi @bonddim. Thank you again for this fantastic contribution! Your previous PR resulted in SONAR-22435, which this PR of yours will fix. Unfortunately, we don't have the resources to test this PR properly, so I will close it now. However, we will reopen it as soon as we can test and apply your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdfile of the respected chart as well as theChart.yamlRefactored dce chart as was promised in Sonarqube chart maintenance #473.
Minor fixes:
Removed:
Refactorings: