Skip to content

Conversation

gabriela-trutan-sonarsource
Copy link
Contributor

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource commented Sep 18, 2025

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Adapt converter to be able to search for any DarawingImage SLVS-2570 Adapt converter to be able to search for any DarawingImage Sep 18, 2025
Copy link

🤖 Pull Request summary

Refactors enum-to-image converter to make it more generic and reusable.

Renamed and moved converter: DependencyRiskImpactSeverityToImageSourceConverterEnumToImageSourceConverter and relocated from DependencyRisks to ReportView namespace
Enhanced flexibility: Added support for custom suffix parameter in resource name pattern (now [EnumValue][CustomSuffix]DrawingImage)
Broadened scope: Converter now accepts any enum type instead of just DependencyRiskImpactSeverity
Updated XAML usage: Modified binding to use new converter with "Severity" parameter to maintain existing functionality

Review focus: Verify the resource naming pattern change doesn't break existing image lookups - the parameter handling logic should maintain backward compatibility when no parameter is provided.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link
Contributor

@vnaskos-sonar vnaskos-sonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource merged commit 3bca58d into feature/report-view Sep 18, 2025
6 checks passed
@gabriela-trutan-sonarsource gabriela-trutan-sonarsource deleted the gt/img-converter branch September 18, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants