Skip to content

SLVS-2519 Show hotspots in the report view panel #6420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 19, 2025
Merged

SLVS-2519 Show hotspots in the report view panel #6420

merged 10 commits into from
Sep 19, 2025

Conversation

gabriela-trutan-sonarsource
Copy link
Contributor

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource commented Sep 18, 2025 •
edited by atlassian bot
Loading

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource marked this pull request as ready for review September 18, 2025 15:07
@sonarqubecloud SonarQubeCloud
Copy link

🤖 Pull Request summary

This pull request integrates security hotspots into the Security Report view alongside the existing dependency risks functionality.

Main changes:

  • New hotspot integration: Added display of security hotspots grouped by file in the report view with priority indicators and tooltips
  • Refactored report structure: Changed from single dependency risk group to multiple group view models supporting both hotspots and dependency risks
  • Enhanced UI components: Added file icons, hotspot severity icons, and improved styling for mixed issue types
  • Simplified filtering: Removed resolution filtering UI and moved selection/telemetry logic to main view model
  • New converters: Added FileNameToMonikerConverter for file type icons and HotspotTooltipConverter for server/local hotspot differentiation

Areas needing review focus:

  • Thread safety of the new ObservableCollection<IGroupViewModel> with collection synchronization
  • Event handling logic for store changes (HotspotsStore_IssuesChanged and DependencyRisksStore_DependencyRiskChanged)
  • UI performance with mixed content types and dynamic grouping by file path

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource mentioned this pull request Sep 19, 2025
Merged
vnaskos-sonar
vnaskos-sonar approved these changes Sep 19, 2025
View reviewed changes
src/IssueViz.Security/ReportView/ReportViewModel.cs
private readonly ITelemetryManager telemetryManager;
private readonly IDependencyRisksStore dependencyRisksStore;
private readonly ILocalHotspotsStore hotspotsStore;
private readonly object @lock = new();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason for adding the @?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lock is a reserved keyword in C#. 😄

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource merged commit 973b20e into feature/report-view Sep 19, 2025
5 checks passed
@gabriela-trutan-sonarsource gabriela-trutan-sonarsource deleted the gt/show-hotspots-report branch September 19, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnaskos-sonar vnaskos-sonar vnaskos-sonar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabriela-trutan-sonarsource @vnaskos-sonar