Skip to content

Conversation

gabriela-trutan-sonarsource
Copy link
Contributor

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource commented Sep 19, 2025

SLVS-2525

This targets the PR in which the ReportViewModel was refactored to prevent crowding it with lots of logic.

Base automatically changed from gt/split-reportvm to feature/report-view September 22, 2025 07:57
Copy link

🤖 Pull Request summary

Adds comprehensive unit tests and refactors security issue reporting architecture.

Test coverage expansion - Adds extensive unit tests for LocalHotspot, AnalysisIssueViewModelBase, GroupFileViewModel, and hotspots/taints report view models
Taint issues integration - Implements TaintViewModel, TaintsReportViewModel and integrates taint issue handling throughout the report view system
Report view model refactoring - Extracts IssuesReportViewModelBase for shared functionality and updates ReportViewModel to handle real-time issue updates via event-driven architecture
Thread safety improvements - Adds collection synchronization to GroupFileViewModel and proper thread handling throughout

Focus areas for review:

  • The event-driven update logic in ReportViewModel.UpdateChangedIssues() - verify issue addition/removal correctly maintains group state
  • Thread synchronization implementation in GroupFileViewModel constructor and collection binding
  • The IsSameAnalysisIssue() comparison logic in AnalysisIssueViewModelBase for proper issue identity matching

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
98.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link
Contributor

@vnaskos-sonar vnaskos-sonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource merged commit 2e97d54 into feature/report-view Sep 23, 2025
5 checks passed
@gabriela-trutan-sonarsource gabriela-trutan-sonarsource deleted the gt/show-taint branch September 23, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants