Skip to content

Conversation

@georgii-borovinskikh-sonarsource
Copy link
Contributor

Part of

@hashicorp-vault-sonar-prod
Copy link

hashicorp-vault-sonar-prod bot commented Nov 28, 2025

SLVS-2719

@sonarqubecloud
Copy link

SonarQube reviewer guide

Summary: Refactor FocusOnNewCodeService to notify SLCore when new code focus is toggled, including move to IssueViz namespace.

Review Focus: Integration with SLCore service provider and async initialization flow. The change makes SLCore initialization blocking (awaited) rather than fire-and-forget, which could impact startup performance.

Start review at: src/SLCore/ISLCoreInstanceHandle.cs. This file contains the critical change from synchronous to async initialization and now blocks on FocusOnNewCodeService initialization, affecting the entire SLCore startup sequence.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vnaskos-sonar vnaskos-sonar marked this pull request as ready for review December 4, 2025 08:29
@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource merged commit 3f27988 into feature/persistent-new-code Dec 4, 2025
6 checks passed
@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource deleted the gb/focus-on-new-code-telemetry branch December 4, 2025 09:50
georgii-borovinskikh-sonarsource added a commit that referenced this pull request Dec 5, 2025
Part of 
<!-- 
  Only for standalone PRs without Jira issue in the PR title: 
    * Replace this comment with Epic ID to create a new Task in Jira
* Replace this comment with Issue ID to create a new Sub-Task in Jira
* Ignore or delete this note to create a new Task in Jira without a
parent
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants