[night-owl] CLI-387 Display detected secret location in git pre-push hook#376
Draft
github-actions[bot] wants to merge 1 commit into
Conversation
Print the secrets binary output (file path and location) before throwing the error when secrets are detected during a push, matching the existing behavior of the pre-commit hook. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CLI-387 — Display detected secret location in git pre-push hook.
Problem
When the
sonarpre-push hook detects a secret, it only printed:No file path, line number, or secret type was shown — leaving the developer with no idea where the secret is.
Fix
Print the secrets binary output (file, location, secret type) before throwing the error, exactly mirroring the pre-commit hook's behavior (
git-pre-commit.ts).After the fix, output looks like:
Tests Updated
tests/integration/specs/hook/hook-git-pre-push.test.ts: two existing "exits 1 with secret" tests now also assertresult.outputcontains the file name (secret.js).Checks Run
prettier --write— no formatting changes needed