CLI-549 Add sonar integrate antigravity command and install orchestration#407
Conversation
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
nquinquenel
force-pushed
the
feature/nq/CLI-549-add-command-antigravity
branch
from
b2809b1 to
24c64c2
Compare
nquinquenel
force-pushed
the
feature/nq/CLI-549-add-command-antigravity
branch
from
24c64c2 to
080e1e8
Compare
Code Review ✅ Approved 2 resolved / 2 findingsIntegrates the 'antigravity' command and orchestration logic, resolving previous issues with test assertions and command descriptions. The implementation includes comprehensive integration tests and centralized path configurations. ✅ 2 resolved✅ Quality: Antigravity command description advertises unimplemented features
✅ Bug: Unawaited rejects assertion makes 'invalid token' test ineffective
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
sophio-japharidze-sonarsource
left a comment
sophio-japharidze-sonarsource
left a comment
There was a problem hiding this comment.
Looks good! I think it's great to go in small increments. I would suggest to target master branch directly but not declare the new feature in command-tree.
| export interface AntigravityIntegrationOptions extends IntegrateAgentOptions { | ||
| projectRoot?: string; | ||
| globalSecretsHookExists?: boolean; | ||
| /** Install PostInvocation SQAA hook (project scope). Wired in CLI-551. */ |
There was a problem hiding this comment.
I think it's fine to drop this comment
There was a problem hiding this comment.
I like to write comments on feature branch to make sure I don't forget about implementation of each tickets, but thanks for suggesting to target master directly! I think it makes sense, I'll remove all the temporary bits I added
| } | ||
|
|
||
| /** | ||
| * Minimal declarative integration for CLI-549 orchestration. Secrets hooks, |
There was a problem hiding this comment.
TMI ? :D
| shouldInstall: () => askUser(), | ||
| }, | ||
| createContextAugmentationFeature<AntigravityIntegrationOptions>({ | ||
| agentDisplayName: 'Antigravity', |
There was a problem hiding this comment.
Will the same integration also work with Antigravity IDE? Or only CLI? Depending on the answer we might want to update this display name or the integration ID on line 32
| claudeIntegration, | ||
| copilotIntegration, | ||
| codexIntegration, | ||
| antigravityIntegration, |
There was a problem hiding this comment.
I think at some point we said we should not have feature branches. So instead I would suggest removing this change / making antigravity command hidden, and merging directly to master. We can also discuss with Damien.
| .addHelpText('after', projectKeyExtraHelp) | ||
| .authenticatedAction((auth, options: IntegrateAgentOptions) => integrateCodex(options, auth)); | ||
|
|
||
| integrateCommand |
There was a problem hiding this comment.
See comment above. Maybe it's best to keep the groundwork but remove wiring from customer-facing surfaces.
| // --------------------------------------------------------------------------- | ||
|
|
||
| /** Antigravity workspace agents directory (relative to the project root). */ | ||
| export const ANTIGRAVITY_PROJECT_AGENTS_DIR = '.agents'; |
There was a problem hiding this comment.
I might be wrong but I vaguely remember Codex also having a similar path? Just something to double-check, not to have duplicate or overwritten integrations
There was a problem hiding this comment.
Do we really need this file? I think similar stuff is covered in the integration test
2 participants
Register integrate antigravity in the command tree, add integrateAntigravity() orchestration, register antigravity-cli in ALL_INTEGRATIONS, and CAG.
More to come
Summary by Gitar
sonar integrate antigravitycommand to orchestrate secrets hooks and agentic integration.integrateAntigravity(), andantigravity-cliintegration declaration.ANTIGRAVITY_PROJECT_AGENTS_DIRand global config paths inconfig-constants.tsfor consistent file placement.This will update automatically on new commits.