myTravel 피드백 반영 및 수정 #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sispo3314
approved these changes
Aug 21, 2025
Contributor
sispo3314
left a comment
sispo3314
left a comment
There was a problem hiding this comment.
제가 코멘트 남겨드린 부분들만 수정하시고 이 브랜치로 푸시하신 후에 병합하면 될 것 같습니다!! 그리고 다음 PR부터는 UI를 확인할 수 있도록 스크린샷이나 동작 영상을 첨부해주시면 좋을 것 같습니다
| <div className="text-center text-heading3 py-2 font-bold text-green1"> | ||
| 나의 여행지 | ||
| <div className="pt-14 px-4 pb-8"> | ||
| <div className="mx-[-1rem] mb-3 rounded-b-xl bg-[#dfead1] pb-3 pt-2"> |
Contributor
There was a problem hiding this comment.
여기 색상코드가 아직 쓰이고 있어요! 피그마 확인하시고 전역 컬러 중에서 써주세요 아마 bg-green3-light로 쓰시면 될 것 같습니다
Comment on lines
41
to
+45
| placeholder="Search" | ||
| className="w-full rounded-xl bg-[#edf0e2] px-4 py-2 pl-10 text-sm focus:outline-none" | ||
| className="w-full rounded-full bg-[#edf0e2] px-4 py-2 pl-10 text-sm text-black placeholder:text-[#7f8c6b] focus:outline-none" | ||
| /> | ||
| <span className="absolute left-3 top-1/2 -translate-y-1/2 text-green-900"> | ||
| 🔍 | ||
| <span className="pointer-events-none absolute left-3 top-1/2 -translate-y-1/2 text-[#7f8c6b]"> | ||
| <img src={SearchIcon} alt="search" className="h-4 w-4" /> |
Contributor
There was a problem hiding this comment.
여기도 아직 전역 컬러가 아닌 색상코드로 쓰이고 있습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 작업 내용
✨ 리뷰어에게
📢 발생한 이슈
📸 스크린샷 (선택)
🔗 관련 이슈
Closes #