refactor(storage-optimization): migrate admin and protocol parameters… - #750
Open
Escelit wants to merge 1 commit into
Open
refactor(storage-optimization): migrate admin and protocol parameters…#750Escelit wants to merge 1 commit into
Escelit wants to merge 1 commit into
Conversation
… from Persistent to Instance storage Migrate Proxy contract (Admin, Implementation, Counter) and CrossChainVerifier (SignerCount) from high-cost Persistent storage to Instance storage to reduce rent fees. Fix broken tests and stale snapshot files.
|
@Escelit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate immutable protocol parameters and admin addresses from high-cost Persistent storage to Instance storage to reduce rent fees.
Changes
Proxy Contract (
contracts/proxy/)Admin,Implementation, andCounterdata keys fromenv.storage().persistent()toenv.storage().instance()Storage(BytesN<32>)remains as Persistent since it holds arbitrary user-defined storageCrossChainVerifier (
contracts/cross-chain-verifier/)SignerCountfrom Persistent to Instance storagetest_verify_message_no_roottest that expected a panic on missing state root (now gracefully returnsfalse)Testing
All 27 tests pass across both contracts:
cargo test --package proxy— 2/2 passedcargo test --package cross-chain-verifier— 25/25 passedCloses #648