feature(gov-multisig): implement M-of-N execution authorization - #769
Merged
Merged
Conversation
Governance proposal execution previously relied on a single admin, creating a single point of failure. Add initialize_with_admins to configure a distinct execution admin set and threshold, and gate execute_proposal behind require_execution_approvals, which requires each of at least `threshold` distinct configured admins to authorize the call. The legacy initialize() keeps a 1-of-1 policy for backwards compatibility. Replaces the removed emergency_guard dependency with soroban_sdk's native require_auth-based approval flow.
Collaborator
|
Nice implementation, LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Governance proposal execution previously relied on a single admin, creating a single point of failure. Add initialize_with_admins to configure a distinct execution admin set and threshold, and gate execute_proposal behind require_execution_approvals, which requires each of at least
thresholddistinct configured admins to authorize the call. The legacy initialize() keeps a 1-of-1 policy for backwards compatibility.Replaces the removed emergency_guard dependency with soroban_sdk's native require_auth-based approval flow.
closes #639