Scroll sensitivity control in each direction #1830
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ortableJS#1875) * deps: install dev-deps for ts, tests and friends * tests: replace test.js with test.ts and fp * change compat tests * ci: replace tests to use npm as per usual
…1878) The doc was missing the case of keeping the default insertion point based on the direction.
* refactor(tests): move HTML fixtures into own dir * refactor(tests): separate e2e tests into folders * refactor(deps): packagejson reformat * refactor(deps): remove cypress from dev deps * refactor(ci): add description to circleci
* refactor(tests): move HTML fixtures into own dir * refactor(tests): separate e2e tests into folders * refactor(deps): packagejson reformat * refactor(deps): remove cypress from dev deps * refactor(ci): add description to circleci * build: bundles with rollup ^2.14 and typescript * dist: create new dist files * chore: bump minor version * build(refactor): removes unused babel plugin
* build: upgrade to 1.11.0 * tests(fix): emit exit code 1 on fail
* build: upgrade to 1.11.0 * tests(fix): emit exit code 1 on fail * refactor: microbundle and typescript * ci: ensure lerna is globally available * build: use yarn and workspaces * use lerna * build: add private to sortbale repo * v1.11.1 * ci: use yarn and lerna together * fix ci * tests: fix tests
…S#1914) * refactor: remove code formattings config files * docs: add more detail to contribution guidelines * docs: remove custom templates * docs: update bug report issue * docs: add discussion template * docs: update featue template
…-links Readme invalid hyperlinks corrected
…ableJS#1921) * refactor: remove code formattings config files * docs: add more detail to contribution guidelines * docs: remove custom templates * docs: update bug report issue * docs: add discussion template * docs: update featue template * fix(build): build dist/sortablejs, was missing prior * build(deps): yarn upgrade * v1.11.2-alpha.4
* refactor: remove code formattings config files * docs: add more detail to contribution guidelines * docs: remove custom templates * docs: update bug report issue * docs: add discussion template * docs: update featue template * fix(build): build dist/sortablejs, was missing prior * build(deps): yarn upgrade * v1.11.2-alpha.4
* refactor: remove code formattings config files * docs: add more detail to contribution guidelines * docs: remove custom templates * docs: update bug report issue * docs: add discussion template * docs: update featue template * fix(build): build dist/sortablejs, was missing prior * build(deps): yarn upgrade * v1.11.2-alpha.4 * fix(build): exports modules correctly This was broken, visible, and closes SortableJS#1891.
Fix/no modules
* Create composer.json * Change project name in composer.json * Fix authors listed in composer.json * Update repo source in composer.json Co-authored-by: Wayne Van Son <[email protected]> * Update "issues" link in composer.json Co-authored-by: Wayne Van Son <[email protected]> * Update homepage link in composer.json Co-authored-by: Wayne Van Son <[email protected]> * Update package name in composer.json Co-authored-by: Wayne Van Son <[email protected]> * Remove legacy file from composer.json files list Co-authored-by: Derek DeRaps <[email protected]> Co-authored-by: Wayne Van Son <[email protected]>
waynevanson
suggested changes
Sep 24, 2020
There was a problem hiding this comment.
Looks like a nice quality of life change, great work!
We had a repo restructure to a monorepo, so we can't tkae your request as is.
Could you add these changes to the files listed below instead?
The new folder is in packages/plugins/auto-scroll/*
@sebastien-prudhomme
Once you add a commit to staging, you can use git commit --amend, then press in order :,wq to save and quit the editor that pops up.
Then force push with git push -uf origin master
sebastien-prudhomme
force-pushed
the
master
branch
from
78b9ff5
to
1380ac3
Compare
|
@waynevanson I've made the change, just let me more time to test it on my application. Also can you confirm that there will be no problem with the switch to TypeScript. |
No worries. Please let me know when you're ready.
No Problem. |
Fix IE11 "SCRIPT16389: Unspecified error." when dragging element Could not pull in SortableJS#1904 due to merge errors, so this PR was created instead.
fix: (IE11 "SCRIPT16389)
|
@waynevanson sorry but i could not manage to test it with the new packaging/typescript way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of a fixed header in my application, i needed to have fine control on scroll sensitivity in the top direction.
Here is the patch i use.
To not break compatibilty i chose to use an object with
top,bottom,leftandrightkeys.