Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-102] Start putting together a web publisher #120

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

Crim
Copy link
Collaborator

@Crim Crim commented Dec 28, 2018

Work in progress for building out a generic pluggable web based publisher for kafka webview (Issue #102)

@Crocatowa
Copy link

Would you like assistance finishing this feature?
I like your webview and recently have discerned a need for this feature myself and would be happy to assist

@Crim
Copy link
Collaborator Author

Crim commented Mar 17, 2020

Would you like assistance finishing this feature?
I like your webview and recently have discerned a need for this feature myself and would be happy to assist

Hey @Crocatowa Sure! I forget exactly where I left off on this, but if you'd like to pick it up and run with it, go for it! :)

@stuart-spradling
Copy link

@Crim , I work with @Crocatowa and have changes I would like to add to this PR for creating a kafka web producer, however I don't have permissions to push to this branch. Please advise :)

@Crim
Copy link
Collaborator Author

Crim commented Mar 24, 2020

@Crim , I work with @Crocatowa and have changes I would like to add to this PR for creating a kafka web producer, however I don't have permissions to push to this branch. Please advise :)

Hi @stuart-spradling ! I believe you should be able to fork the repository, including this branch into your fork. You can then create and push a branch to your forked repository and commit your code. Once you feel its ready for review/merging, you can send over a pull request.

this website might explain the process better than I can. If you run into troubles let me know.

As a somewhat related note, would you like me to resolve the conflicts in this branch so you have a clean spot to start from?

@stuart-spradling
Copy link

stuart-spradling commented Mar 25, 2020

As a somewhat related note, would you like me to resolve the conflicts in this branch so you have a clean spot to start from?

@Crim That would be great, thanks! I tried resolving it on my own and I may have broken some of the MessageFormat tests

@Crim
Copy link
Collaborator Author

Crim commented Mar 26, 2020

@stuart-spradling I think that should update the branch with master and resolve any checkstyle/header violations.

Unsure where I left this, so can't really speak to the state of the tests passing or failing without digging more into it.

Let me know if you have any questions, happy to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants