Merged
Conversation
FlorianUekermann
force-pushed
the
fix-windows
branch
from
3a4c71a to
be5cc17
Compare
FlorianUekermann
force-pushed
the
fix-windows
branch
from
be5cc17 to
c35e48e
Compare
kevincox
approved these changes
Feb 16, 2026
Comment on lines
+54
to
+55
| #[cfg(not(target_os = "windows"))] network_interface: Option<&str>, | ||
| #[cfg(target_os = "windows")] network_interface: Option<std::net::IpAddr>, |
Collaborator
There was a problem hiding this comment.
A function argument changing type is pretty nasty. But defining a trait seems like overkill. The other option is moving this to a method but I get that we want to strongly encourage callers to set it. I think this is fine for now.
Contributor
Author
There was a problem hiding this comment.
Yeah, it does not look great, but it's the only solution I can think of that forces the caller to use this correctly. I don't see how a trait would even work for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.