✨ Remove unwanted objects during upgrade with hook server #258
aniruddha2000pr-lint.yml
on: pull_request
Lint Pull Request
2m 49s
Annotations
10 errors and 11 warnings
|
Lint Pull Request:
pkg/release/release.go#L54
File is not `gci`-ed with --skip-generated -s standard,default (gci)
|
|
Lint Pull Request:
internal/controller/clusteraddon_controller.go#L364
string `BeforeClusterUpgrade` has 4 occurrences, make it a constant (goconst)
|
|
Lint Pull Request:
extension/handlers/hooks.go#L37
importShadow: shadow of imported from 'sigs.k8s.io/controller-runtime/pkg/client' package 'client' (gocritic)
|
|
Lint Pull Request:
internal/controller/clusteraddon_controller.go#L461
hugeParam: in is heavy (144 bytes); consider passing it by pointer (gocritic)
|
|
Lint Pull Request:
internal/controller/clusteraddon_controller.go#L496
hugeParam: in is heavy (144 bytes); consider passing it by pointer (gocritic)
|
|
Lint Pull Request:
internal/controller/clusteraddon_controller.go#L571
hugeParam: in is heavy (144 bytes); consider passing it by pointer (gocritic)
|
|
Lint Pull Request:
internal/controller/clusteraddon_controller.go#L684
hugeParam: in is heavy (144 bytes); consider passing it by pointer (gocritic)
|
|
Lint Pull Request:
internal/controller/clusteraddon_controller.go#L710
hugeParam: stage is heavy (112 bytes); consider passing it by pointer (gocritic)
|
|
Lint Pull Request:
internal/controller/clusteraddon_controller.go#L908
hugeParam: in is heavy (144 bytes); consider passing it by pointer (gocritic)
|
|
Lint Pull Request:
internal/controller/clusteraddon_controller.go#L958
hugeParam: in is heavy (144 bytes); consider passing it by pointer (gocritic)
|
|
Lint Pull Request
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Lint Pull Request:
pkg/clusteraddon/clusteraddon.go#L17
package-comments: package comment should be of the form "Package clusteraddon ..." (revive)
|
|
Lint Pull Request:
pkg/clusteraddon/clusteraddon.go#L33
error-naming: error var ConditionNotMatchError should have name of the form ErrFoo (revive)
|
|
Lint Pull Request:
pkg/clusteraddon/clusteraddon.go#L43
exported: exported type Object should have comment or be unexported (revive)
|
|
Lint Pull Request:
pkg/clusteraddon/clusteraddon.go#L51
exported: exported type WaitForCondition should have comment or be unexported (revive)
|
|
Lint Pull Request:
pkg/clusteraddon/clusteraddon.go#L56
exported: exported type Stage should have comment or be unexported (revive)
|
|
Lint Pull Request:
pkg/clusteraddon/clusteraddon.go#L63
exported: exported type ClusterAddonConfig should have comment or be unexported (revive)
|
|
Lint Pull Request:
pkg/clusteraddon/clusteraddon.go#L69
exported: exported function ParseClusterAddonConfig should have comment or be unexported (revive)
|
|
Lint Pull Request:
api/v1alpha1/conditions_const.go#L63
exported: comment on exported const FailedToDeleteObjectsReason should be of the form "FailedToDeleteObjectsReason ..." (revive)
|
|
Lint Pull Request:
api/v1alpha1/clusteraddon_types.go#L31
exported: exported const StageAnnotation should have comment or be unexported (revive)
|
|
Lint Pull Request:
api/v1alpha1/clusteraddon_types.go#L33
exported: exported type StageAnnotationValue should have comment or be unexported (revive)
|