🌱 Create a Generic client to download release assets #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guettli
force-pushed
the
tg/create-generic-client-to-download-release-assets-via-oci
branch
from
02664fc
to
f9e696e
Compare
janiskemper
force-pushed
the
tg/create-generic-client-to-download-release-assets-via-oci
branch
2 times, most recently
from
8b637cd
to
564bc7e
Compare
create a generic assetsclient interface Current code is opinionated towards the github client for downloading the assets, instead we need a more generic approach that can incorporate other plugins (oci-registry) too. Signed-off-by: Thomas Guettler <[email protected]> Signed-off-by: janiskemper <[email protected]>
janiskemper
force-pushed
the
tg/create-generic-client-to-download-release-assets-via-oci
branch
from
564bc7e
to
454b031
Compare
janiskemper
approved these changes
Jun 24, 2024
janiskemper
deleted the
tg/create-generic-client-to-download-release-assets-via-oci
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Current code is opinionated towards the github client for downloading the assets, instead we need a more generic approach that can incorporate other plugins (oci-registry) too.
This PR create a generic assetsclient interface. This interface will be implemented for github and for oci-artifacts.
TODOs: