Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add github integration tests #19

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

nitisht
Copy link
Contributor

@nitisht nitisht commented Oct 6, 2023

What this PR does / why we need it:
This PR adds integration tests to test the release asset download flow from github

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@nitisht nitisht requested a review from batistein October 6, 2023 05:48
@nitisht nitisht changed the title Add github integration tests 🌱 Add github integration tests Oct 6, 2023
@nitisht nitisht force-pushed the nitisht/gh-integration branch 3 times, most recently from 2404388 to be455ee Compare October 6, 2023 06:19
@berendt
Copy link
Member

berendt commented Oct 6, 2023

We use Zuul CI. The use of Github Actions should be avoided. I would prefer not to build everything on Github Actions first and then migrate it all.

Benjamin recently wrote a Zuul users guide. It's available at https://docs.scs.community/dev-docs/operations/operations/zuul-ci-cd-quickstart-user-guide.

A good example for the use of Zuul is in the https://github.com/SovereignCloudStack/k8s-cluster-api-provider repository.

I think someone from the Zuul team can also give a hands-on.

There is also a dedicated Matrix room: #scs-zuul:matrix.org

Makefile Outdated Show resolved Hide resolved
@jschoone
Copy link
Contributor

jschoone commented Oct 6, 2023

We use Zuul CI. The use of Github Actions should be avoided. I would prefer not to build everything on Github Actions first and then migrate it all.

Benjamin recently wrote a Zuul users guide. It's available at https://docs.scs.community/dev-docs/operations/operations/zuul-ci-cd-quickstart-user-guide.

A good example for the use of Zuul is in the https://github.com/SovereignCloudStack/k8s-cluster-api-provider repository.

I think someone from the Zuul team can also give a hands-on.

There is also a dedicated Matrix room: #scs-zuul:matrix.org

Thanks for raising this. We are aware of it but agreed to use GitHub Actions here to move faster.
A later use of another CI tool is not such a big hassle. Due to the container meeting not taking place, I forgot to report. If there is any ambiguity, it should be deferred to an appropriate meeting.

@janiskemper
Copy link
Member

blocked by #20 and until there is a second release in cluster-stacks named docker-ferrol-1-27-v1

@nitisht nitisht force-pushed the nitisht/gh-integration branch 3 times, most recently from bf03a49 to 882799d Compare October 12, 2023 07:18
Signed-off-by: Nitish Tiwari <[email protected]>
@nitisht
Copy link
Contributor Author

nitisht commented Oct 12, 2023

blocked by #20 and until there is a second release in cluster-stacks named docker-ferrol-1-27-v1

Now that #20 is closed, can we take this in?

@janiskemper janiskemper merged commit e7ad502 into main Oct 12, 2023
6 checks passed
@janiskemper janiskemper deleted the nitisht/gh-integration branch October 12, 2023 07:47
janiskemper pushed a commit that referenced this pull request Nov 28, 2023
@jschoone jschoone added the Container Issues or pull requests relevant for Team 2: Container Infra and Tooling label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants