Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Hook server and Tilt setup #56

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

aniruddha2000
Copy link
Member

@aniruddha2000 aniruddha2000 commented Jan 24, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes

Special notes for your reviewer:

  • hook server and Tilt setup

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • Adaption of Controller
  • squash commits
  • include documentation
  • add unit tests

@aniruddha2000 aniruddha2000 marked this pull request as ready for review February 7, 2024 11:31
@aniruddha2000
Copy link
Member Author

@janiskemper I tested the PR and the runtime hook server is working well, but the issue is can I merge the PR without squashing all commits? as you can see this PR got quite a lot of weird commits and I don't have the permission to update the addons branch with main

@janiskemper
Copy link
Member

we can change permissions in the end and do that. No worries ;)

@jschoone jschoone linked an issue Feb 8, 2024 that may be closed by this pull request
@janiskemper
Copy link
Member

I realized we did the PRs wrongly. This PR does not fix #35. We need to make a PR from addons branch on main, which will fix #35.

Can you create a new PR from addons branch to main (WIP: Multi-stage Cluster Addons) @aniruddha2000, update this description to be clearer on the scope of this PR (hook server). Then we merge this and can make the PR #61 on addons branch instead of the feature branch.

If you say, I can also do this.

@janiskemper janiskemper changed the title ✨ Multi-stage cluster addons Hook server and Tilt setup Feb 13, 2024
Signed-off-by: Aniruddha Basak <[email protected]>
@janiskemper janiskemper changed the title Hook server and Tilt setup ✨ Hook server and Tilt setup Feb 14, 2024
@janiskemper janiskemper merged commit d724741 into addons Feb 14, 2024
6 of 7 checks passed
@janiskemper janiskemper deleted the ani-syself/add-hook-server branch February 14, 2024 09:39
@jschoone jschoone added the Container Issues or pull requests relevant for Team 2: Container Infra and Tooling label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants