🐛 Fix Git client for public repos #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two bugs happen with public repos and no git token set: - isPrivateRepo does not work as an error is returned if the git client was not successfully built. This commit replaces the utility function. - there was no handling of redirects that Github API gives us for downloading release assets in the case of public repos. This commit adds it. Signed-off-by: janiskemper <[email protected]>
batistein
approved these changes
Sep 19, 2023
janiskemper
added a commit
that referenced
this pull request
Nov 28, 2023
🌱 add version info to the binary via ldflags.
jschoone
added
the
Container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Two bugs happen with public repos and no git token set:
TODOs: