Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 update to go 1.21 #63

Merged
merged 1 commit into from
Mar 3, 2024
Merged

🌱 update to go 1.21 #63

merged 1 commit into from
Mar 3, 2024

Conversation

kranurag7
Copy link
Contributor

@kranurag7 kranurag7 commented Feb 14, 2024

this commit updates to go 1.21 and alpine 3.19.1
version.

Fixes #22

Signed-off-by: kranurag7 [email protected]

@kranurag7 kranurag7 changed the title 🌱 update to go 1.21 in cso repo 🌱 update to go 1.21 Feb 14, 2024
@janiskemper janiskemper requested review from batistein and removed request for janiskemper February 14, 2024 15:48
@kranurag7 kranurag7 marked this pull request as ready for review February 20, 2024 13:09
Copy link
Member

@chess-knight chess-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you run make builder-image-push ? Or do you have to merge this first to the main?
And what about .builder-image-version.txt?

@kranurag7
Copy link
Contributor Author

kranurag7 commented Feb 20, 2024

Most of the things here are automated (similar to cspo repo) but since we don't have renovate in this repo, I'll have to do it manually I think. #71

@kranurag7 kranurag7 mentioned this pull request Feb 27, 2024
5 tasks
@jschoone jschoone added the Container Issues or pull requests relevant for Team 2: Container Infra and Tooling label Feb 27, 2024
this commit updates to go 1.21 and alpine 3.19.1
version.

Signed-off-by: kranurag7 <[email protected]>
@kranurag7
Copy link
Contributor Author

@chess-knight everything is updated now and I think this PR is ready to be merged.
I'll merge it now but feel free to ask any questions regarding this.

My other PR of CAPI upgrade depends on this.
#80

And what about .builder-image-version.txt?

This is the central point of interaction when you're working with make targets locally.
We store a variable in Makefile which is BUILDER_IMAGE_VERSION = $(shell cat .builder-image-version.txt) and we read this file to get the latest version of the container image.

@kranurag7 kranurag7 merged commit 6ce9d64 into main Mar 3, 2024
6 checks passed
@kranurag7 kranurag7 deleted the kr/update-to-go-1-21 branch March 3, 2024 09:44
kranurag7 added a commit that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Go to 1.21
4 participants