Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate creation of standards overview pages #116

Merged
merged 32 commits into from
Dec 14, 2023
Merged

Automate creation of standards overview pages #116

merged 32 commits into from
Dec 14, 2023

Conversation

mbuechse
Copy link
Contributor

resolves #97

@mbuechse
Copy link
Contributor Author

@fkr
Copy link
Member

fkr commented Nov 21, 2023

One thing that comes immediately to mind: the colors are not explained.
Am far from having a clue about how visually-impaired people would see this page, but I think, if we color-code the status of the standard in the overview table, this should also be apparent to visually-impaired people.

@maxwolfs
Copy link
Contributor

Great!

Regarding the Colors:

One thing that comes immediately to mind: the colors are not explained. Am far from having a clue about how visually-impaired people would see this page, but I think, if we color-code the status of the standard in the overview table, this should also be apparent to visually-impaired people.

good point! I was unsure during drafting this and now I also have a better proposal. We could add the Icons for Draft, Merged and Draft and still use the color codings:

image

@fkr
Copy link
Member

fkr commented Nov 21, 2023

Excellent suggestion @maxwolfs

@mbuechse
Copy link
Contributor Author

Once SovereignCloudStack/standards#388 is merged, I can remove all the md files under standards/. 🎉

resolves #97

Signed-off-by: Matthias Büchse <[email protected]>
Signed-off-by: Matthias Büchse <[email protected]>
then multiline values will work, for instance:

```yaml
description: |
  line1
  line2
```

Signed-off-by: Matthias Büchse <[email protected]>
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Copy link
Contributor Author

I changed the emojis. Still not perfect, but no longer color-coded, and probably not too hard to figure out (and we can always add a legend/key to the symbols):
Screenshot from 2023-11-28 15-17-11

@mbuechse
Copy link
Contributor Author

mbuechse commented Nov 30, 2023

Added a first draft of generated scope overview:
Screenshot from 2023-11-30 15-53-29

@mbuechse
Copy link
Contributor Author

mbuechse commented Dec 1, 2023

Screenshot from 2023-12-01 13-42-02

Rebuilt because v2 has turned obsolete last night. We should do nightly builds...

Signed-off-by: Matthias Büchse <[email protected]>
Signed-off-by: Matthias Büchse <[email protected]>
Signed-off-by: Matthias Büchse <[email protected]>
@anjastrunk anjastrunk self-requested a review December 7, 2023 12:06
- SCS-open
- SCS-sovereign
2. _cloud layer_, of which there are two:
- infastructure as a service (IaaS)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- infastructure as a service (IaaS)
- Infastructure as a Service (IaaS)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to capitalize the word service, because it's just a regular word. Wikipedia agrees: https://en.wikipedia.org/wiki/As_a_service

- SCS-sovereign
2. _cloud layer_, of which there are two:
- infastructure as a service (IaaS)
- Kubernetes as a service (KaaS)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Kubernetes as a service (KaaS)
- Kubernetes as a Service (KaaS)

@anjastrunk
Copy link
Contributor

anjastrunk commented Dec 8, 2023

In Scopes and versions, three state of standards are called draft, stable and deprecated.
In SCS Compatible IaaS, the same three states are called obsolete, effective, and preview. The same applies all tables under "Standards".

To avoid any confusion, we should be consisted and I prefer draft, stable and deprecated

Copy link
Contributor

@anjastrunk anjastrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

@maxwolfs
Copy link
Contributor

When I try to run everything in a newly clone repo locally with npm install the .gitignore lines 16, 28 and 29 are somehow not working. All generated files are tracked. Any idea?

@mbuechse
Copy link
Contributor Author

In Scopes and versions, three state of standards are called draft, stable and deprecated. In SCS Compatible IaaS, the same three states are called obsolete, effective, and preview. The same applies all tables under "Standards".

To avoid any confusion, we should be consisted and I prefer draft, stable and deprecated

This is a real problem. I think we should distinguish between two concepts:

  • the editorial state of the version: this can be draft, stable, or deprecated.
  • the effectiveness of the version given the current date: this can be preview, effective, obsolete (better words welcome).

For example, the version can be deprecated with a deprecation date in the future, and then the version is still effective. Marking it deprecated in this table would be misleading from my POV.

@mbuechse
Copy link
Contributor Author

mbuechse commented Dec 13, 2023

If we want to merge the two concepts, we obtain five states, I think:

  • preview (ineffective and draft)
  • soon-to-be-effective (ineffective and stable)
  • effective (effective and stable)
  • soon-to-be-obsolete (effective and deprecated)
  • obsolete (ineffective and deprecated)

Again: better words welcome!

@mbuechse
Copy link
Contributor Author

mbuechse commented Dec 13, 2023

Sorry, I made a mistake. The situation that I described does not apply to certification scope versions, but to individual standards. There we have a field status that can be Proposal, Draft, Stable, Deprecated, or Rejected, together with fields for stabilized_on and deprecated_on. For scope versions, no such status field exists, so there is no such editorial status.

@mbuechse
Copy link
Contributor Author

mbuechse commented Dec 13, 2023

Still, with certificate scope versions, even without any explicit status field, we have the following:

  • no stabilized_on --> preview
  • stabilized_on in the future --> soon-to-be-effective
  • stabilized_on not in the future and deprecated_on not present --> effective
  • stabilized_on not in the future and deprecated_on in the future --> soon-to-be-obsolete
  • stabilized_on not in the future and deprecated_on not in the future --> obsolete

@mbuechse
Copy link
Contributor Author

When I try to run everything in a newly clone repo locally with npm install the .gitignore lines 16, 28 and 29 are somehow not working. All generated files are tracked. Any idea?

I fixed it. The lines were not sufficient.

Copy link
Contributor

@maxwolfs maxwolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great work! From my POV the status messages fit now.

I have noted the optimisation possibilities of collecting content from same repos in the package.json and splitting the track intro content from the code. But IMO nice-to-haves that do not block this from being merged.

@mbuechse mbuechse merged commit e285faf into main Dec 14, 2023
4 of 5 checks passed
@mbuechse mbuechse deleted the issue/97 branch December 14, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate creation of standards overview pages
4 participants