-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create How to guide for security groups #142
Conversation
Add the guide plus best practices groups. Signed-off-by: josephineSei <[email protected]>
Did a first review, see review comments. Things I didn't address yet:
|
fix some spelling mistakes and the wording of the introduction Co-authored-by: Markus Hentsch <[email protected]> Signed-off-by: josephineSei <[email protected]>
This is a good idea.
I wonder, does the documentation already has some internal "standard" for this? Because it is important and I would from now on continue with writing all OpenStack resources with capital letters: Ports, Security Groups, Volumes, Server / VM, Network, etc..
I was also thinking about this. But after looking into the default quotas for Security Groups (that is 10 btw) I am a bit afraid that we would recommend to many groups. But maybe we should recommend different ways? Like:
|
Signed-off-by: Markus Hentsch <[email protected]>
Signed-off-by: Markus Hentsch <[email protected]>
Signed-off-by: josephineSei <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good additions!
I added some minor spelling and phrasing improvement suggestions.
I also changed all occurences of "Security Group(s)" to lowercase to align it with the existing paragraphs.
One thing I'm wondering is how we should approach the spelling of "VM" vs "virtual machine". Currently, we seem to use both.
Co-authored-by: Markus Hentsch <[email protected]> Signed-off-by: josephineSei <[email protected]>
@markus-hentsch I added your suggestions. @artificial-intelligence and @bitkeks could you please look over this guide and state, whether this is security-focused enough? You both indicated, that you wanted to have a more security-focused guide in the DR. |
Signed-off-by: josephineSei <[email protected]>
Co-authored-by: Markus Hentsch <[email protected]> Signed-off-by: josephineSei <[email protected]>
Will merge this after final CI run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was asked to review this, after it's already merged.
It's mostly looking good to me, some minor nits could be improved, but that should be discussed in a version 2 of this document imho.
Add the guide plus best practices groups. Signed-off-by: josephineSei <[email protected]> Co-authored-by: Markus Hentsch <[email protected]>
Instead of a standard, the security groups just allow a guide for best practice including basic recommended security groups.
This is part of the ticket: SovereignCloudStack/standards#473