Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to v2 test for PCO1,2,3. Add PCO4 and AOV. #164

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

garloff
Copy link
Contributor

@garloff garloff commented Mar 18, 2024

Also include direct links to dashboards with mycloud set correctly for the PCO cloud regions (they are all on the same grafana host)..

Also include direct links to dashboards with mycloud set correctly
for the PCO cloud regions (they are all on the same grafana host)..

Signed-off-by: Kurt Garloff <[email protected]>
@garloff garloff added bug Something isn't working enhancement New feature or request standards Issues / ADR / pull requests relevant for standardization & certification labels Mar 18, 2024
@garloff garloff self-assigned this Mar 18, 2024
Copy link
Member

@maxwolfs maxwolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maxwolfs
Copy link
Member

Signed-off-by: Kurt Garloff <[email protected]>
@garloff
Copy link
Contributor Author

garloff commented Mar 19, 2024

The Cert of https://apimon.services.regio.digital/public-dashboards/17cf094a47404398a5b8e35a4a3968d4 has expired.

Yeah, I noticed the failed CI action and sent a notification to Christian last night. We should not wait for the fix though, IMVHO, as our PR is not causing the regression. (As the CI pipeline stops, we take a small risk that tests happening after the failed cert don't run and thus we don't see the outcome.)

@garloff garloff merged commit 85d95d0 into main Mar 19, 2024
3 of 4 checks passed
@garloff garloff deleted the feat/add-pco4-aov-fix-pco123-stdver branch March 19, 2024 07:56
JuanPTM pushed a commit to JuanPTM/docs that referenced this pull request Jun 3, 2024
)

* Link to v2 test for PCO1,2,3. Add PCO4 and AOV.
  Also include direct links to dashboards with mycloud set correctly
  for the PCO cloud regions (they are all on the same grafana host)..
* Fix capitalization of aov.

Signed-off-by: Kurt Garloff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request standards Issues / ADR / pull requests relevant for standardization & certification
Projects
Status: Published
Development

Successfully merging this pull request may close these issues.

2 participants