Upgrade Docusaurus to V3 and fixes #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Max Wolfs <[email protected]>
3 tasks
mbuechse
reviewed
Apr 2, 2024
| @@ -44,7 +44,7 @@ line to commit messages. | |||
| ```bash | |||
| My fancy commit message | |||
|
|
|||
| Signed-off-by: Christian Berendt <[email protected]> | |||
| Signed-off-by: Christian Berendt <$[email protected]> | |||
There was a problem hiding this comment.
I can live fine with most changes, but this seems wrong.
There was a problem hiding this comment.
No, this is a code segment, so the escape character will not be interpreted. Why did you put it in there?
There was a problem hiding this comment.
While touching this, can we change the sample mail address to [email protected] ?
Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Max Wolfs <[email protected]>
mbuechse
approved these changes
Apr 2, 2024
berendt
reviewed
Apr 3, 2024
package.json
Outdated
| "@docusaurus/preset-classic": "^2.4.3", | ||
| "@docusaurus/theme-mermaid": "^2.4.3", | ||
| "@easyops-cn/docusaurus-search-local": "^0.33.6", | ||
| "@docusaurus/core": "^3.1.1", |
There was a problem hiding this comment.
Docusaurus 3.2.0 is out now. I think it makes sense to change this before the merge of this PR.
Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Max Wolfs <[email protected]>
JuanPTM
pushed a commit
to JuanPTM/docs
that referenced
this pull request
Jun 3, 2024
* upgrade dependencies Signed-off-by: Max Wolfs <[email protected]> * fix glossary Signed-off-by: Max Wolfs <[email protected]> * fix new md rules Signed-off-by: Max Wolfs <[email protected]> * fix md errors Signed-off-by: Max Wolfs <[email protected]> * fix reviews comment Signed-off-by: Max Wolfs <[email protected]> * remove pointless escaping Signed-off-by: Max Wolfs <[email protected]> * update to 3.2.0 Signed-off-by: Max Wolfs <[email protected]> * change sample mail address Signed-off-by: Max Wolfs <[email protected]> * bump node Signed-off-by: Max Wolfs <[email protected]> * fix md linting typo Signed-off-by: Max Wolfs <[email protected]> * update docusaurus Signed-off-by: Max Wolfs <[email protected]> * fix url Signed-off-by: Max Wolfs <[email protected]> * fix link Signed-off-by: Max Wolfs <[email protected]> --------- Signed-off-by: Max Wolfs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade and relevant fixes to the new md rules coming with it. This is only fixing the markdown errors with the markdown files within this repository. There are still 14 compilation that prevent from building. Those have to be fixed in other repositories. See parent issue #113