-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color coding to the to standards table in the docs page #211
Add color coding to the to standards table in the docs page #211
Conversation
…overview.md file to .mdx format.
Regarding colors and high contrast ratio: The colors I picked are all relatively light pastel colors: However, if you wish other colors, please give feedback. Also the stable and effective colors could be swapped imo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! I would like to build something based on this, and I think 95 % of your work can be used for that. I have the following desiderata:
- I have the impression that the colors are being set using plain JavaScript. So I would try to not use React, but onload or something.
- I absolutely hate that the whole
populateStds.js
has been reformatted. I would like to keep reformatting and semantic change separate (using separate PRs). But I don't even see the need for the reformatting.
Regarding react: I used react here, because the docusaurus documentation says that if you want to enrich markdown with more features (e.g. coloring), use react: see here Second, the reformatting was somehow done automatically, I'll try to figure out why and reverse it. |
I probably won't become a fan of Docusaurus, but so be it. Thanks for the explanation! |
…ge the overview.md file to .mdx format.
…ge the overview.md file to .mdx format.
…ge the overview.md file to .mdx format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one minor thing: dark mode. Maybe we can postpone dark mode. If you can address it right away, all the better.
I have already approved it, noting that we can postpone dark mode. Go ahead! |
…ng-to-standards-table
…ng-to-standards-table
Added the color mapping with a react component. Needed to change the overview.md file to .mdx format.
related issue: 445