Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ansible-styleguide #40

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Add ansible-styleguide #40

merged 1 commit into from
Jul 10, 2023

Conversation

ra-beer
Copy link
Contributor

@ra-beer ra-beer commented Jul 10, 2023

Signed-off-by: Ramona Beermann [email protected]

@ra-beer ra-beer force-pushed the feature/add_ansible_styleguide branch from 6ae5f4d to 402f1fc Compare July 10, 2023 04:17
@ra-beer ra-beer requested review from berendt and maxwolfs July 10, 2023 04:18
maxwolfs
maxwolfs requested changes Jul 10, 2023
View reviewed changes
Copy link
Member

@maxwolfs maxwolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one typo otherwise lgtm!
One question though: Should we put when and become into code blocks to easier distinguish those parameters from text?

community/contribute/styleguides/ansible_styleguide.md Outdated Show resolved Hide resolved
Add ansible-styleguide
814f330 
Signed-off-by: Ramona Beermann <[email protected]>
@ra-beer ra-beer force-pushed the feature/add_ansible_styleguide branch from 402f1fc to 814f330 Compare July 10, 2023 06:00
@ra-beer ra-beer merged commit db57866 into main Jul 10, 2023
@ra-beer ra-beer deleted the feature/add_ansible_styleguide branch July 10, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwolfs maxwolfs maxwolfs approved these changes

@berendt berendt Awaiting requested review from berendt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ra-beer @maxwolfs