Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: main.rs, log error #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

prochac
Copy link

@prochac prochac commented Jan 1, 2025

The error had format w/o argument. The error variable was unused.

The error had format w/o argument. The `error` variable was unused.
@gbin
Copy link

gbin commented Jan 1, 2025

Got that from the AUR package on Arch along some warnings:

error: 1 positional argument in format string, but no arguments were given
   --> src/main.rs:532:88
    |
532 |         Err(error) => panic!("A massive error occured, not sure whats goin on here: \n {}"),
    |                                                                                        ^^

warning: unused imports: `ImageSource` and `epaint::ColorImage`
  --> src/main.rs:12:27
   |
12 | use eframe::{egui::{self, ImageSource}, epaint::ColorImage};
   |                           ^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused variable: `error`
   --> src/main.rs:532:13
    |
532 |         Err(error) => panic!("A massive error occured, not sure whats goin on here: \n {}"),
    |             ^^^^^ help: if this is intentional, prefix it with an underscore: `_error`
    |
    = note: `#[warn(unused_variables)]` on by default

warning: `pineflash` (bin "pineflash") generated 2 warnings
error: could not compile `pineflash` (bin "pineflash") due to 1 previous error; 2 warnings emitted
==> ERROR: A failure occurred in build().
    Aborting...
error: failed to build 'pineflash-git-0.5.5+2.r309.20241230.1cbe554-1':
error: packages failed to build: pineflash-git-0.5.5+2.r309.20241230.1cbe554-1

@prochac
Copy link
Author

prochac commented Jan 3, 2025

@prochac
Copy link
Author

prochac commented Jan 3, 2025

Probably caused by this:
#83

@gbin
Copy link

gbin commented Jan 3, 2025

@acuteaangle 🥺

@acuteaangle
Copy link
Contributor

Welp, that’s incredibly embarrassing ;-;
I had caught this locally, but must have skipped a git add before amending the commit :/

Sorry for the build error :c

Adding ‘learn how pre-commit works’ to my todo

acuteaangle added a commit to acuteaangle/pineflash that referenced this pull request Jan 4, 2025
This adds GitHub Actions integration to automatically build (and run
tests, should they be added in the future) on Windows, MacOS, and Linux.

This will (hopefully) prevent issues like Spagett1gh-87 (introduced by Spagett1gh-83)
from recurring in the future.

Related-to: Spagett1gh-83, Spagett1gh-86, Spagett1gh-87
acuteaangle added a commit to acuteaangle/pineflash that referenced this pull request Jan 4, 2025
This adds GitHub Actions integration to automatically build (and run
tests, should they be added in the future) on Windows, MacOS, and Linux.

This will (hopefully) prevent issues like Spagett1gh-87 (introduced by Spagett1gh-83)
from recurring in the future.

Related-to: Spagett1gh-83, Spagett1gh-86, Spagett1gh-87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants