Implement RPQ-matrix reachability algorithm #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solver logic was moved out main public function. Also this patch adds input validation. Signed-off-by: Rodion Suvorov <[email protected]>
This patch add documentation with explaining of RPQ-matrix algorithm work. Signed-off-by: Rodion Suvorov <[email protected]>
Remove unused label function and old logic from check function. Signed-off-by: Rodion Suvorov <[email protected]>
Signed-off-by: Rodion Suvorov <[email protected]>
Signed-off-by: Rodion Suvorov <[email protected]>
In previous versions there was a logic mistakes in processing of L and R kleene stars. Now they are correct. Also provide a docs. Signed-off-by: Rodion Suvorov <[email protected]>
In this patch all kleene stars was slightly changed - Identity matrix name changes from E to I - All tmp matrices T was demolished - R kleene logic changed from S <- A T <- S x B S <- S + T to S <- A S <- S x (B + I) - L kleene logic changed in the same way Signed-off-by: Rodion Suvorov <[email protected]>
Add spaces before ; and add docs for struct in include. Signed-off-by: Rodion Suvorov <[email protected]>
This patch fixes typo in the name of RPQ-matrix main function. Correct in include and algorithm directories. Signed-off-by: Rodion Suvorov <[email protected]>
This patch fixes incorrect assertions in check and in main functions. Also some refactor Signed-off-by: Rodion Suvorov <[email protected]>
In previous commit about kleene logic I start use result matrix S as input and output. I guess this leads to UB. So i come back to tmp matrices. Signed-off-by: Rodion Suvorov <[email protected]>
This patch adds tests for valid and invalid input. Signed-off-by: Rodion Suvorov <[email protected]>
Author
|
I've created new "stable" branch for this PR because our stable branch is a little bit old |
This patch brings old kleene logic back: - R kleene: S <- A S <- S x (B + I) - L kleene: S <- B S <- (A + I) x S Also all kleene stars now implemented via accumulator without creation new tmp matrices. Signed-off-by: Rodion Suvorov <[email protected]>
Author
|
Some work still needed |
Signed-off-by: Rodion Suvorov <[email protected]>
suvorovrain
commented
Oct 8, 2025
Comment on lines
474
to
475
| sr = GrB_LOR_LAND_SEMIRING_BOOL ; | ||
| op = GxB_LOR_BOOL_MONOID ; |
Author
There was a problem hiding this comment.
Maybe I can choose faster rings? Let me know please.
Member
|
@suvorovrain I have pushed the fixes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds RPQ-matrix reachability algorithm from Diego Arroyuelo, Adrián Gómez-Brandón & Gonzalo Navarro paper "Evaluating regular path queries on compressed adjacency matrices".