FO identifier and other changes #4202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happens for me when I try to save a local identifier (not permitted on FOs). Note the catch on the Identifier endpoint *and* the catch on the Promise.all from the header bar are *both* required to avoid an RSOD (red screen of death).
Otherwise if you save an FO and then click New, store.reset.identifier still has all of the saved data except for id. (At one point I thought not resetting store.identifier.identifier.namespace_id in particular might be an issue, but I might just be confused.)
STR (there are multiple ways) * save an FO with an identifier (or load a saved FO with an identifier) * change only the namespace of the identifier, either by searching, selecting, or creating new * click save * reload the page * see the namespace didn't save with the new value, it has the original value (because store.identifier.isUnsaved is never set to true in this case) I gated save on presence of identifier and namespace in addition to isUnsaved since `isUnsaved` can go to true if the user enters only a namespace or only an identifier (or enters both and then removes one), I think the resulting exception might have been swallowed previously? Not sure.
Per discussion, leaving the store in-tree in case we decide to bring it back.
jlpereira
reviewed
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly changes to the Catalog Number panel (not currently in use) in New FO, but also:
totalto be > 0 when not absent (already required to be == 0 when absent).