Skip to content

Conversation

@definitelynotagoblin
Copy link
Contributor

@definitelynotagoblin definitelynotagoblin commented Jul 24, 2025

Description

We'd like to decouple Sharphound development from necessarily referencing latest Common lib stable release. Would rather it builds against latest main branch developments for PR merge checks.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

Summary by CodeRabbit

  • Chores
    • Updated build process to use newer versions of build and release tools.
    • Improved handling of specific package versions during the build process.

@definitelynotagoblin definitelynotagoblin self-assigned this Jul 24, 2025
@definitelynotagoblin definitelynotagoblin added the enhancement New feature or request label Jul 24, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jul 24, 2025

Walkthrough

The GitHub Actions build workflow was updated to use newer versions of the checkout, .NET setup, and release actions. A new step was added to replace SharpHoundCommon and SharpHoundRPC package versions with 0.0.0-git-dev in all .csproj files before dependency restoration. The workflow trigger was changed to run only on pull request events of types "opened" and "synchronize."

Changes

File(s) Change Summary
.github/workflows/build.yml Changed workflow trigger to PR events only; upgraded checkout, setup-dotnet, and release actions versions; added step to replace package versions with 0.0.0-git-dev in .csproj files before restoring dependencies.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub Actions
    participant Workflow Steps
    participant Shell Script

    GitHub Actions->>Workflow Steps: Start build workflow on PR open/synchronize
    Workflow Steps->>actions/checkout@v4: Checkout code
    Workflow Steps->>actions/setup-dotnet@v4: Setup .NET
    Workflow Steps->>Shell Script: Replace package versions with '0.0.0-git-dev'
    Shell Script-->>Workflow Steps: Versions updated in .csproj
    Workflow Steps->>dotnet: Restore dependencies
    Workflow Steps->>dotnet: Build project
    Workflow Steps->>softprops/action-gh-release@v2: Release update
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

  • chore: SHC ref bump to v4.3.0 #162: Both PRs involve changes related to the versions of SharpHoundCommon and SharpHoundRPC, with this PR updating them dynamically in the build workflow and the related PR updating them statically in the project file.

Suggested reviewers

  • ktstrader

Poem

A bunny hopped through YAML fields,
Upgrading actions for smoother yields.
With git-dev in every .csproj line,
The workflow now is quite divine!
Release hops too, from v1 to v2—
Oh, what a build this rabbit grew! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4f86d9 and c82ced8.

📒 Files selected for processing (1)
  • .github/workflows/build.yml (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/build.yml
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shc-git-dev-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
.github/workflows/build.yml (1)

34-44: Consider robust semantic replacement instead of regex-sed

Direct XML editing via regex is brittle (multi-line tags, additional attributes, whitespace).
For long-term maintainability:

  1. Use xmlstarlet or dotnet msbuild transformations.
  2. Or add a Directory.Packages.props/NuGet.Config pointing SharpHound* packages to a git-dev source and omit inline version numbers.

This avoids future breakage when tag formatting changes.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 45f843c and 51a65ca.

📒 Files selected for processing (1)
  • .github/workflows/build.yml (2 hunks)

@definitelynotagoblin definitelynotagoblin marked this pull request as draft July 24, 2025 21:19
@definitelynotagoblin definitelynotagoblin marked this pull request as ready for review July 24, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants