-
Notifications
You must be signed in to change notification settings - Fork 226
feat: build pipeline should target SHC git-dev for merge status checks #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.X
Are you sure you want to change the base?
Conversation
WalkthroughThe GitHub Actions build workflow was updated to use newer versions of the checkout, .NET setup, and release actions. A new step was added to replace Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Workflow Steps
participant Shell Script
GitHub Actions->>Workflow Steps: Start build workflow on PR open/synchronize
Workflow Steps->>actions/checkout@v4: Checkout code
Workflow Steps->>actions/setup-dotnet@v4: Setup .NET
Workflow Steps->>Shell Script: Replace package versions with '0.0.0-git-dev'
Shell Script-->>Workflow Steps: Versions updated in .csproj
Workflow Steps->>dotnet: Restore dependencies
Workflow Steps->>dotnet: Build project
Workflow Steps->>softprops/action-gh-release@v2: Release update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related PRs
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/build.yml (1)
34-44: Consider robust semantic replacement instead of regex-sedDirect XML editing via regex is brittle (multi-line tags, additional attributes, whitespace).
For long-term maintainability:
- Use
xmlstarletordotnet msbuildtransformations.- Or add a
Directory.Packages.props/NuGet.ConfigpointingSharpHound*packages to agit-devsource and omit inline version numbers.This avoids future breakage when tag formatting changes.
Description
We'd like to decouple Sharphound development from necessarily referencing latest Common lib stable release. Would rather it builds against latest main branch developments for PR merge checks.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Summary by CodeRabbit